Workaround pybind11 bug on Windows when CMAKE_BUILD_TYPE=RelWithDebInfo #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
This should pass now:
|
|
This patch is terrible bad but:
Without a proper fix in |
ivanpauno
requested review from
thomas-moulard,
jikawa-az and
nuclearsandwich
and removed request for
a team
|
I'm not really in a position to evaluate the fitness here but I appreciate the head's up. Hopefully it's something we can push upstream in short order. |
|
I removed the |
|
It would be good to fix this upstream, @ivanpauno are you able open a PR and reference it in this change so that we can revert it after an upstream release? |
jacobperron
reviewed
Oct 13, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
approved these changes
Oct 14, 2020
|
CI:
|
delete-merged-branch
bot
deleted the
ivanpauno/rosbag2_py_rel_with_deb_info
branch
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
…nfo (#538) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
sloretz
added a commit
to ros2/rclpy
that referenced
this pull request
Feb 16, 2021
Copies windows debug fixes from rosbag2_py for using Pybind11 on Windows debug and RelWithDebInfo. For more info see the original PRs ros2/rosbag2#538 ros2/rosbag2#531 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
…nfo (#538) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
sloretz
added a commit
to ros2/rclpy
that referenced
this pull request
Feb 23, 2021
Copies windows debug fixes from rosbag2_py for using Pybind11 on Windows debug and RelWithDebInfo. For more info see the original PRs ros2/rosbag2#538 ros2/rosbag2#531 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
to ros2/rclpy
that referenced
this pull request
Feb 24, 2021
* Copy windows debug fixes for pybind11 Copies windows debug fixes from rosbag2_py for using Pybind11 on Windows debug and RelWithDebInfo. For more info see the original PRs ros2/rosbag2#538 ros2/rosbag2#531 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Workaround for consistent Py_DEBUG macro Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * fix argument order Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Does PUBLIC Py_DEBUG resolve differences? Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Don't include Python.h if including pybind11.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove Py_DEBUG if target doesn't use pybind11 Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another workaround for a pybind11 bug ...
I should start sending patches upstream (for this and #504).
When that gets included in a new pybind11 release, we can update our vendor package and get rid of these workarounds (I will open an issue to track that).
Though it failed in a packaging build, only
-DCMAKE_BUILD_TYPE=RelWithDebInfois needed to reproduce the issue:TODO: This still doesn't pass, I have to check more closely in a Windows VM.CI is passing now.Fixes #537.